Audit panics and add clippy lints#84
Merged
kurtjd merged 1 commit intoOpenDevicePartnership:mainfrom Dec 20, 2025
Merged
Conversation
kurtjd
requested review from
JWL-surface,
RobertZ2011,
asasine,
ayodejiige and
bramsdell-ms
asasine
approved these changes
Dec 20, 2025
jerrysxie
approved these changes
Dec 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audits for additional panics, predominantly with the
embassyfeature enabled. No breaking changes introduced, in a couple instances I could convert an unwrap to aPdError::InvalidParamswhich seemed to make the most sense in those cases.This PR also additionally addresses a few clippy warnings unrelated to panics. I had to bump the MSRV from 1.82 to 1.88 since currently there is already existing code that is not stable under 1.83 which clippy warned about (and since the code was already introduced, I don't think there's any harm in bumping the MSRV officially).
Resolves #83