Fix metadata order when downloading from data view #1748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jh-RLI
reviewed
Jul 1, 2024
Contributor
jh-RLI
left a comment
jh-RLI
left a comment
There was a problem hiding this comment.
We have agreed that branch names should only contain "-" and no "/" or "_" :) but don't change this here, just as an information for future branch names.
| # Metadata related # | ||
| ############################################## | ||
|
|
||
| def order_metadata(metadata: dict) -> dict: |
Contributor
There was a problem hiding this comment.
👍 If you agree that this is good enough. There is still a slight difference (1. download while using the oemetabuilde 2. download while viewing the table detail page) because this only sorts the "top" level key´s. I think it's fine.
Contributor
Author
There was a problem hiding this comment.
could adapt this also, so that key order is preserved recursively
Contributor
There was a problem hiding this comment.
Right, that could be a quick solution. Then I would vote for implementing it : in favour of everything being as similar as possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the discussion
Fix inconsistent metadata structure
Type of change (CHANGELOG.md)
Changes
Workflow checklist
Automation
Closes #1696
PR-Assignee
Reviewer