-
Notifications
You must be signed in to change notification settings - Fork 24
Add oep-datasets rest-api #2071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jh-RLI
wants to merge
15
commits into
develop
Choose a base branch
from
feature-1971-add-oep-datasets
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+493
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le creation orchestration
- Add model to dataedit app which n:m relation to tables - Add hybrid api endpoint for read and create datasets - Use DRF serializer to handle client data from request - add service to handle dataset creation - add migration - add serializer to process table assignment client request data - add serializer to list dataset resource with data from table model - Add views to edit / delete datasets, assign tables as ressources to a dataset - list dataset resources (tables)
- Make sure every table got a minimal set of oemetadata resource information in case the user did not provide any info - Adding oemetadata on table creation from latest template if no metadata is provided - Auto set some values: name, topics, fields(name, data type and nullable)
…esource metadata by only reading out the resources[0] element and add it to the dataset metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the discussion
Since oemetadata v2 was released, we introduced datasets. Currently only the metadata supports creating them, there is no API or UI which could be used to create a dataset, list availabale datasets or even edit datasets.
This PR implements datasets in the OEP and adds a REST-API as first step. Later on the Upload-Wizard will reworked and enhanced for dataset support.
Type of change (CHANGELOG.md)
Features
Add Dataset rest-api and metadata based concept as specified in oemetadata / frictionless (#2071)
Documentation updates
Workflow checklist
Automation
Closes #1971
PR-Assignee
Reviewer