Skip to content

Conversation

@josephjclark
Copy link
Collaborator

@josephjclark josephjclark commented Dec 22, 2025

Short Description

This PR allows credentials to be passed to the CLI. When running a workflow with Lightning credential UUIDs, users can pass a value for each id.

Fixes #210 and part of the #1186 epic

Implementation Details

This PR does several things:

  • Allow --credential to passed to the CLI, which is a path to a JSON object which maps
  • The CLI will apply credentials in the map to the incoming execution plan before the runtime gets hold of it
  • Note that configuration strings which are paths, like my-cred.json, still work (although I don't know why we need this)
  • When pulling from lightning, project credentials are written to step.configuration

It may be interesting to note that the credential map is not supported at all by the runtime. Just like the Worker, its the CLI's responsibility to resolve credentials into a manageable, executable form.

Other work

Probably not in this PR, but here is some related stuff wot needs looking at?

  • DONE We should support yaml credential maps
  • Maybe credential ids can be partial? Makes sense with UUIDS but probably not with user ids
  • Later, add the credential map to the Workspace (I've paused because do we default it?)
  • Work out how to support keychain credentials

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to know!):

  • Code generation (copilot but not intellisense)
  • Learning or fact checking
  • Strategy / design
  • Optimisation / refactoring
  • Translation / spellchecking / doc gen
  • Other
  • I have not used AI

You can read more details in our Responsible AI Policy

@github-project-automation github-project-automation bot moved this to New Issues in v2 Dec 22, 2025
@josephjclark josephjclark changed the base branch from main to release/next December 22, 2025 13:24
@josephjclark
Copy link
Collaborator Author

It would be really nice, when pulling a project, if we could:

  1. generate a credential map with empty values and a nice comment
  2. warn the user if we detect any unset credentials. So we need a validateCredentialMap function.

This is probably for later

@josephjclark josephjclark merged commit 3e63c08 into release/next Dec 25, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from New Issues to Done in v2 Dec 25, 2025
@josephjclark josephjclark deleted the credential-map branch December 25, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

CLI: Credential store

2 participants