This repository was archived by the owner on Dec 5, 2018. It is now read-only.
Replace Twitter button with ShareThis including Twitter, Facebook, Pinterest, and Email#67
Open
msscully wants to merge 2 commits intoOpenHackIC:masterfrom
Open
Replace Twitter button with ShareThis including Twitter, Facebook, Pinterest, and Email#67msscully wants to merge 2 commits intoOpenHackIC:masterfrom
msscully wants to merge 2 commits intoOpenHackIC:masterfrom
Conversation
Twitter and Facebook buttons were different sizes so used ShareThis to get matching Twitter, Facebook, Pinterest, and Email shring buttons.
Contributor
There was a problem hiding this comment.
Thanks for doing this! It looks great...
I haven't had a chance to test it locally yet, but do we still include the hashtag, text, and link in a similar way? Or does it just use the current location?
Contributor
Author
|
Was thinking about this on the way home. Url defaults to page url. Can set it using st_url. We can also set the title using st_title, which defaults to document.title, st_via for a default 'via @whomever on twitter, and st_msg for customizing the message. I'm working on a change incorporating these features. |
Contributor
|
Cool, thanks. :) We should get a Twitter account, maybe... @AdoptaLOL seems to be abandoned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Twitter and Facebook buttons were different sizes so used ShareThis to
get matching Twitter, Facebook, Pinterest, and Email shring buttons.