collect change #550
Open
collect change #550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openminddev
requested changes
Oct 30, 2025
Comment on lines
+50
to
+51
| # self.auido_pub = None | ||
| # There was a typo(auido -> audio) |
Contributor
There was a problem hiding this comment.
Suggested change
| # self.auido_pub = None | |
| # There was a typo(auido -> audio) |
Comment on lines
+63
to
+64
| # self.auido_pub = self.session.declare_publisher(self.audio_topic) | ||
| # There was a typo(auido -> audio) |
Contributor
There was a problem hiding this comment.
Suggested change
| # self.auido_pub = self.session.declare_publisher(self.audio_topic) | |
| # There was a typo(auido -> audio) |
Comment on lines
+82
to
+84
| #if self.auido_pub: | ||
| # self.auido_pub.put(self.audio_status.serialize()) | ||
| # There was a typo(auido -> audio) |
Contributor
There was a problem hiding this comment.
Suggested change
| #if self.auido_pub: | |
| # self.auido_pub.put(self.audio_status.serialize()) | |
| # There was a typo(auido -> audio) |
| logging.info("Elevenlabs TTS Zenoh client opened") | ||
| except Exception as e: | ||
| logging.error(f"Error opening Elevenlabs TTS Zenoh client: {e}") | ||
| # In case of error, only log is printed and there is no return. |
Contributor
There was a problem hiding this comment.
Suggested change
| # In case of error, only log is printed and there is no return. |
Comment on lines
+149
to
+151
| # if self.auido_pub: | ||
| # self.auido_pub.put(state.serialize()) | ||
| # There was a typo(auido -> audio) |
Contributor
There was a problem hiding this comment.
Suggested change
| # if self.auido_pub: | |
| # self.auido_pub.put(state.serialize()) | |
| # There was a typo(auido -> audio) |
Contributor
|
@sungchancho Thanks for your PR. Could you please remove the comments? |
Author
|
I'll check and delete it. Can I still get the badge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
[Provide a brief overview of the changes in this pull request.]
Changes
[Detail the changes you have made in this pull request. Include any new features, bug fixes, or improvements.]
Testing
[Describe the testing you have done to verify your changes. Include any relevant details about the test environment and the results of your tests.]
Impact
[Explain the impact of your changes. Include any potential risks or side effects that reviewers should be aware of.]
Additional Information
[Include any additional information that may be relevant to reviewers. This could include links to related issues or pull requests, references to documentation, or other context that may help reviewers understand your changes.]