Skip to content

Conversation

@roamingengineer311
Copy link
Contributor

@roamingengineer311 roamingengineer311 commented Oct 30, 2025

  • Move cleanup-test-vm-template.yml closer to the end of role execution
  • Add OneFlow validation (instantiates a simple 2-VM service, checks it status and cleans it up)
  • Updated report generating task with using 3rd tab for error messages
  • moved vnet deletion to cleanup-test-vm-template
  • fixed some minor flaws

Resolves OpenNebula/engineering#441

@roamingengineer311 roamingengineer311 added the enhancement New feature or request label Oct 30, 2025
@tinova tinova requested a review from dandrushko October 30, 2025 09:38
@balazsbme
Copy link
Collaborator

Did you manage to run a test together with the other testcases, e.g. running something similar as the local test example? when all otehr testcases are enabled, except FE HA and VM HA? We need to test backward compatbility of the changes.

@roamingengineer311
Copy link
Contributor Author

Did you manage to run a test together with the other testcases, e.g. running something similar as the local test example? when all otehr testcases are enabled, except FE HA and VM HA? We need to test backward compatbility of the changes.

TASKS RECAP ***********************************************************************************************************************************************************************
Thursday 27 November 2025  16:18:55 +0000 (0:00:00.021)       0:04:24.861 ***** 
=============================================================================== 
oneflow_validation : OneFlow | Wait for service state RUNNING ------------------------------------------------------------------------------------------------------------- 40.69s
/opt/one-deploy-validation/roles/oneflow_validation/tasks/main.yml:76 ------------------------------------------------------------------------------------------------------------
test_vm : Wait for VM come up --------------------------------------------------------------------------------------------------------------------------------------------- 25.50s
/opt/one-deploy-validation/roles/test_vm/tasks/main.yml:50 -----------------------------------------------------------------------------------------------------------------------
validation : Check services restart --------------------------------------------------------------------------------------------------------------------------------------- 22.53s
/opt/one-deploy-validation/roles/validation/tasks/core_services_verification.yml:36 ----------------------------------------------------------------------------------------------
test_vm : Wait until the test VM is deleted ------------------------------------------------------------------------------------------------------------------------------- 14.54s
/opt/one-deploy-validation/roles/test_vm/tasks/main.yml:102 ----------------------------------------------------------------------------------------------------------------------
Host id: 0 -- Wait for VM come up ----------------------------------------------------------------------------------------------------------------------------------------- 13.76s
/opt/one-deploy-validation/playbooks/tasks/conn_matrix_per_host.yml:45 -----------------------------------------------------------------------------------------------------------
test_vm : Verify that VM image is in ready state -------------------------------------------------------------------------------------------------------------------------- 13.63s
/opt/one-deploy-validation/roles/test_vm/tasks/main.yml:35 -----------------------------------------------------------------------------------------------------------------------
validation : Populate service facts --------------------------------------------------------------------------------------------------------------------------------------- 12.49s
/opt/one-deploy-validation/roles/validation/tasks/core_services_verification.yml:16 ----------------------------------------------------------------------------------------------
Generate SSH key pair for conn-matrix -------------------------------------------------------------------------------------------------------------------------------------- 9.40s
/opt/one-deploy-validation/playbooks/conn-matrix.yml:7 ---------------------------------------------------------------------------------------------------------------------------
validation : Set host offline and then set online -------------------------------------------------------------------------------------------------------------------------- 7.01s
/opt/one-deploy-validation/roles/validation/tasks/core_services_verification.yml:194 ---------------------------------------------------------------------------------------------
Download test VM template and image from the Marketplace ------------------------------------------------------------------------------------------------------------------- 4.61s
/opt/one-deploy-validation/playbooks/prepare-test-vm-template.yml:6 --------------------------------------------------------------------------------------------------------------
oneflow_validation : OneFlow | Cleanup temporary template ------------------------------------------------------------------------------------------------------------------ 3.75s
/opt/one-deploy-validation/roles/oneflow_validation/tasks/main.yml:194 -----------------------------------------------------------------------------------------------------------
oneflow_validation : OneFlow | Cleanup service (normal delete) ------------------------------------------------------------------------------------------------------------- 3.74s
/opt/one-deploy-validation/roles/oneflow_validation/tasks/main.yml:184 -----------------------------------------------------------------------------------------------------------
oneflow_validation : OneFlow | Instantiate the service --------------------------------------------------------------------------------------------------------------------- 3.50s
/opt/one-deploy-validation/roles/oneflow_validation/tasks/main.yml:59 ------------------------------------------------------------------------------------------------------------
Save the output of the hostname command to the hostname variable ----------------------------------------------------------------------------------------------------------- 3.33s
/opt/one-deploy-validation/playbooks/validation.yml:18 ---------------------------------------------------------------------------------------------------------------------------
oneflow_validation : OneFlow | Create service template --------------------------------------------------------------------------------------------------------------------- 2.67s
/opt/one-deploy-validation/roles/oneflow_validation/tasks/main.yml:30 ------------------------------------------------------------------------------------------------------------
oneflow_validation : OneFlow | Get VM count -------------------------------------------------------------------------------------------------------------------------------- 2.66s
/opt/one-deploy-validation/roles/oneflow_validation/tasks/main.yml:113 -----------------------------------------------------------------------------------------------------------
network-benchmark : Install ping dependencies ------------------------------------------------------------------------------------------------------------------------------ 2.53s
/opt/one-deploy-validation/roles/network-benchmark/tasks/network_benchmark.yml:3 -------------------------------------------------------------------------------------------------
validation : Install ping dependencies ------------------------------------------------------------------------------------------------------------------------------------- 2.48s
/opt/one-deploy-validation/roles/validation/tasks/core_services_verification.yml:9 -----------------------------------------------------------------------------------------------
Gathering Facts ------------------------------------------------------------------------------------------------------------------------------------------------------------ 2.43s
/opt/one-deploy-validation/playbooks/conn-matrix.yml:2 ---------------------------------------------------------------------------------------------------------------------------
Install ping dependencies -------------------------------------------------------------------------------------------------------------------------------------------------- 2.29s
/opt/one-deploy-validation/playbooks/conn-matrix.yml:88 --------------------------------------------------------------------------------------------------------------------------

Copy link
Collaborator

@balazsbme balazsbme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the validation.run_one_flow flag in this file: https://github.com/OpenNebula/one-deploy-validation/blob/master/inventory/reference/group_vars/all.yml

One flow does not require any custom configuration right? so we expect in most deployments to work out of the box, right? if that's the case we please set to enabled in the file linked above.

Otherwise, e.g. for VM HA we need to install host error hooks, fencing agent, etc. so that is why it is disabled by defualt in the reference.

@roamingengineer311
Copy link
Contributor Author

Add the validation.run_one_flow flag in this file: https://github.com/OpenNebula/one-deploy-validation/blob/master/inventory/reference/group_vars/all.yml

One flow does not require any custom configuration right? so we expect in most deployments to work out of the box, right? if that's the case we please set to enabled in the file linked above.

Otherwise, e.g. for VM HA we need to install host error hooks, fencing agent, etc. so that is why it is disabled by defualt in the reference.

updated, pls check

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is still under core_services. it should be directly under validation:

validation.run_one_flow could you check if we can control enabling/disabling the TC from the variable?

As I remember, I had problems with overwriting from here, when I had set the role-level defaults...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my mistake, updated

…validation, added minor changes to other roles

Signed-off-by: Dmitrii Gilev <dgilev@opennebula.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants