-
Notifications
You must be signed in to change notification settings - Fork 4
F OpenNebula/engineering#441: Added OneFlow validation #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
033f96f to
f8b1942
Compare
ceffe02 to
706e7dd
Compare
|
Did you manage to run a test together with the other testcases, e.g. running something similar as the local test example? when all otehr testcases are enabled, except FE HA and VM HA? We need to test backward compatbility of the changes. |
|
706e7dd to
2423260
Compare
balazsbme
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the validation.run_one_flow flag in this file: https://github.com/OpenNebula/one-deploy-validation/blob/master/inventory/reference/group_vars/all.yml
One flow does not require any custom configuration right? so we expect in most deployments to work out of the box, right? if that's the case we please set to enabled in the file linked above.
Otherwise, e.g. for VM HA we need to install host error hooks, fencing agent, etc. so that is why it is disabled by defualt in the reference.
2423260 to
a344f0b
Compare
updated, pls check |
a344f0b to
532a073
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is still under core_services. it should be directly under validation:
validation.run_one_flow could you check if we can control enabling/disabling the TC from the variable?
As I remember, I had problems with overwriting from here, when I had set the role-level defaults...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my mistake, updated
…validation, added minor changes to other roles Signed-off-by: Dmitrii Gilev <dgilev@opennebula.io>
532a073 to
f81bb39
Compare
Resolves OpenNebula/engineering#441