Feature/mk 0.8.1 #6
Conversation
* feature/ipc: [chore] update yarn.lock Start fleshing out the IPC system
| await exit(0) | ||
| } else { | ||
| await run({camelName, argv}) | ||
| await exit(0) |
There was a problem hiding this comment.
What does this mean? Does exit(0) return a promise? /me is confused
|
|
||
| let ipcEnabled = false | ||
|
|
||
| export const enableIpc = () => { |
There was a problem hiding this comment.
Suggestion, why not making it idempotent?
| } | ||
|
|
||
| export const notify = ({key, value}) =>{ | ||
| if (ipcEnabled === true && process.send) { |
There was a problem hiding this comment.
Curiosity: when could process.send() be null? (I'd also be happy with a "google is your friend" answer)
|
|
||
| const ctx = { | ||
| argv: argv_ | ||
| argv: argv._ |
| }, | ||
| "dependencies": { | ||
| "measurement-kit": "^0.1.0-alpha.5" | ||
| "measurement-kit": "^0.1.0-alpha.8" |
There was a problem hiding this comment.
Thing that wonders me: the versioning of Node bindings is not aligned with the version of MK. Do you think that this may be a problem? FTR for Android we use ${mk_version}-${bindings-version}.
|
|
||
| PKG_TMPL = """ | ||
| { | ||
| "name": "ooni-{{nettest_dash_case}}", |
| ['HTTP Invalid Request Line', 'http-invalid-request-line'], | ||
| ['HTTP Header Field Manipulation', 'http-header-field-manipulation'], | ||
| #['NDT', 'ndt'], | ||
| ['Dash', 'dash'], |
| done: Sequelize.BOOLEAN | ||
| done: Sequelize.BOOLEAN, | ||
| dataUsageUp: Sequelize.INTEGER, | ||
| dataUsageDown: Sequelize.INTEGER |
There was a problem hiding this comment.
Yeah, better to keep them separate
| countryPath: geoipCountryPath, | ||
| asnPath: geoipAsnPath, | ||
| } | ||
| } |
There was a problem hiding this comment.
If I understand this file correctly, you download files if missing. Maybe you can add the version number to the file so that you know if you have the latest version (or find some other strategy)?
|
|
||
| // These don't exist in MK | ||
| whatsapp: makeNettestLoader('whatsapp'), | ||
| captivePortal: makeNettestLoader('captive-portal'), |
There was a problem hiding this comment.
CaptivePortal actually exists. (Maybe it's not wrapped?)
| @@ -1,3 +1,4 @@ | |||
|
|
|||
There was a problem hiding this comment.
You can probably tweak the template substitution to avoid adding an empty line here
bassosimone
left a comment
bassosimone
left a comment
There was a problem hiding this comment.
I did a read of the whole diff as of 760038e leaving comments and asking questions. Overall, I really like what I see. Good work 👍
This branch includes integration for IM tests and updates to the latest version of Measurement Kit