-
Notifications
You must be signed in to change notification settings - Fork 2
Open PROT changes to pldm-lib. #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
embediver
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good now, a few small details still.
The added pldm-interface is hard to review in depth since documentation is missing mostly and there are no (unit-)tests.
We can merge it assuming that its good for now, but an issue regarding documentation and tests would be good.
8ecd2ad to
9bf3ee4
Compare
0e82659 to
bb8ac82
Compare
|
Looks good to me now 👍🏼 Just one small thing: |
bb8ac82 to
dcd1baf
Compare
|
One doc test is failing in The import needs to be changed from |
dcd1baf to
fbeb820
Compare
Async executor removed. Firmware device api, fd_ops and fd_internal, will be in a Hubris driver task.