Skip to content

Conversation

@CourtneyDrant
Copy link
Collaborator

Async executor removed. Firmware device api, fd_ops and fd_internal, will be in a Hubris driver task.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 30, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@CourtneyDrant CourtneyDrant self-assigned this Sep 30, 2025
Copy link
Collaborator

@embediver embediver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good now, a few small details still.

The added pldm-interface is hard to review in depth since documentation is missing mostly and there are no (unit-)tests.

We can merge it assuming that its good for now, but an issue regarding documentation and tests would be good.

@CourtneyDrant CourtneyDrant force-pushed the openprot branch 3 times, most recently from 8ecd2ad to 9bf3ee4 Compare December 17, 2025 22:57
@CourtneyDrant CourtneyDrant force-pushed the openprot branch 5 times, most recently from 0e82659 to bb8ac82 Compare December 18, 2025 01:21
@embediver
Copy link
Collaborator

Looks good to me now 👍🏼

Just one small thing:
The CI wasn't configured for a cargo workspace environment, thus the tests only run on the root package.
Adding the --workspace option to the the cargo test invocation should be sufficient to also cover unit tests from the pldm-common and pldm-interface. All other checks should be ok as they are for now.
I noticed that one doc-test is failing when testing this, but the change is small, the import just needs to be changed from pldm_lib to pldm_common there.

@embediver
Copy link
Collaborator

One doc test is failing in pldm-common/src/protocol/firmware_update.rs:356 f..

The import needs to be changed from pldm_lib to pldm_common.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants