Free, close, and unlink files when failure happens #1407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelrsweet
requested changes
Nov 4, 2025
Member
michaelrsweet
left a comment
michaelrsweet
left a comment
There was a problem hiding this comment.
The unlink is necessary. The close calls are not since we are exiting (which will close the files for us).
Remove freeing the free list.
michaelrsweet
requested changes
Nov 10, 2025
Member
michaelrsweet
left a comment
michaelrsweet
left a comment
There was a problem hiding this comment.
Just clean up temp files. We don't need to close files right before exiting.
|
|
||
| sleep(5); | ||
|
|
||
| if (snmp_fd >= 0) |
| { | ||
| _cupsLangPrintFilter(stderr, "ERROR", | ||
| _("The printer is not responding.")); | ||
| if (snmp_fd >= 0) |
Contributor
Author
There was a problem hiding this comment.
httpAddrClose, which is what the other close calls, unlinks too.
Member
There was a problem hiding this comment.
Only for Unix domain sockets. SNMP uses UDP sockets which have no corresponding local file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.