scheduler: Fix possible use_after_free in cupsdReadClient()
#1454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `cupsdSendHeader()` fails, we free the connection and return -1, but in that case we try to free the connection again in `cupsdReadClient()`.
zdohnal
force-pushed
the
osh-fixes-post-cve
branch
from
7d6c912 to
c1d2c63
Compare
zdohnal
changed the title
check_start_tlscupsdReadClient()
michaelrsweet
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
cupsdSendHeader()fails, we free the connection and return -1, but in that case we try to free the connection again incupsdReadClient().