-
Notifications
You must be signed in to change notification settings - Fork 272
Adding back Gentoo Prefix support #769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 50a338b.
5b1176a to
798afad
Compare
This will place the RC_SVCDIR to ${gentooprefix}/run/openrc. In Gentoo
Prefix, user may not have root permission to use /run/openrc, and can
only access directories inside ${gentooprefix}
RC_PREFIX is now always set to ${gentooprefix}
Signed-off-by: Yiyang Wu <xgreenlandforwyy@gmail.com>
|
i'll talk to the folks about PREFIX, seems like it wasn't well supported. but specially now that openrc-user is being merged, we might have a better case to keep it. |
|
I reached out to the prefix team multiple times about this in the past, and there didn't seem to be any interest in supporting it. This is the reason it was removed, so I'm against this unless we have more interest from that team. |
Thank you for explanation. @heroxbd is the Lead of Prefix Project and also my mentor. He talked to me privately that we need OpenRC support in Gentoo Prefix and should maintain it, and that's why I created this PR. |
|
Hi William,
I hope everything is going on well. Did you contact me via my email or IRC? Sorry that I missed your message. I am still catch up with my inbox. We are interested in supporting OpenRC on Prefix. The previous stopper was the Prefix support for meson, which is now fixed. Please assign future bugs and request review of PRs to the Prefix team (and me) regarding Prefix support of OpenRC when you see appropriate. Yours, |
|
with #942, openrc will take svcdir from the env var RC_SVCDIR, and respect XDG_CONFIG_DIRS for init scripts. i'll follow it up with another patch for rc.conf, so it'll be possible to add those two changes move the build time checks this PR adds to runtime checks, does gentoo prefix need anything else? i'd rather not have |
I think setting the correct RC_PATH and RC_SVCDIR is enough for prefix. Thank you! |
|
closing this as #942 was merged. please let me know if any other issues pop up with prefix support! |
This reverts 50a338b and continues #672
@heroxbd and I use openrc inside Gentoo Prefix to manage services, so we'd like to see this feature back