Adds Brake Fix, Buy, and Dinghy Slide running sounds. #12
+11
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I have rebased this to account for the changes made to this project since I made this commit. |
Member
|
I will look at this again tonight. One thing I will say though, since these are soundfx from a royalty free library, if anyone decides to make their own recordings for these, they might overwrite these. Should've probably done this a while back. Sorry about that. |
karst
requested changes
Apr 13, 2025
Member
karst
left a comment
karst
left a comment
There was a problem hiding this comment.
I have a few comments on the provided files.
If you need any help with balancing I'll gladly do that for you.
The samples overview in the json:
"samples": [
"$[0..3]",
"samples/click_in.flac",
"samples/click_out.flac",
"$[0..3]",
"samples/scream_el_zadra.flac",
"$[0..2]",
"samples/buy1.flac",
"$[0..3]",
"samples/train_whistle_1_cp_railroad.flac",
"samples/train_whistle_depart_cp_railroad.flac",
"$[0..1]",
"samples/hydrolics_wh_lost_gravity.flac",
"samples/hydrolics_wh_space_shot.flac",
"$[0..3]",
"samples/rain.flac",
"samples/thunder_3.flac",
"samples/thunder_4.flac",
"$[0..0]",
"samples/dinghy_slide.flac",
"samples/pop.flac",
"SoundFX/brake_fix.flac",
"$[0..0]",
"samples/flush.flac",
"samples/click_in.flac",
"$[0..0]",
"samples/news.flac",
"$[0..7]",
"samples/hydrolics_mm_ninja.flac",
"samples/hydrolics_el_abyssus.flac",
"samples/error.flac",
"samples/hydrolics_tow_truck.flac",
"samples/hyper_rc_lift_cp_magnum_xl_200.flac",
"samples/wood_rc_lift_cp_blue_streak.flac",
"$[0..1]",
"samples/bm_rc_lift_cp_rougarou.flac",
"samples/bm_rc_roar_cp_rougarou_pa_oziris.flac",
"$[0..4]",
"samples/crowd.flac"
]
karst
approved these changes
Jul 23, 2025
Member
|
Everything's good now. Sorry for taking so long. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also adds an attributions file. Format is not finalized (this is heavily based on OpenTTD's OpenSFX's equivalent file), but I needed to get this here to properly attribute these sounds (as the CC BY license requires this).Superceded by the now-official file, PR rebased to reflect this.