forked from devaslanphp/help-desk
-
Notifications
You must be signed in to change notification settings - Fork 1
Perbaikan compser #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ujgsp
wants to merge
15
commits into
development
Choose a base branch
from
perbaikan-compser
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deskripsi
patches\filament-forms-access-level.patchcweagans\composer-patches ke require-devbaca patch inidocs/filament-compatibility.mdscripts->post-autoload-dumpsection di composer.json📌 Kenapa perlu pakai patch dengan cweagans/composer-patches
Saat kamu upgrade dari Filament v2 ke Filament v3, ada perubahan API internal yang belum sepenuhnya kompatibel. Salah satunya adalah method getFormStatePath() di trait InteractsWithForms yang awalnya protected, tetapi di kelas lain (mis. Filament\Resources\Pages\ViewRecord) membutuhkan visibility yang lebih luas (public).
PHP memiliki aturan ketat tentang method visibility inheritance:
Dalam kasus ini errornya:
Hal ini terjadi di dalam paket Filament itu sendiri (vendor), bukan di kode aplikasi kamu. Sementara:
👉 Karena itu solusi sementara tapi dapat diulang secara otomatis adalah dengan menggunakan package cweagans/composer-patches untuk mem‐patch file vendor setiap kali Composer melakukan install/update.
Plugin ini memungkinkan kamu untuk:
✅ menetapkan patch yang otomatis diaplikasikan pada vendor
✅ version control patch tersebut (disimpan di repositori kamu)
✅ tidak perlu edit vendor/ secara manual setiap kali install/update
Dengan begitu patch bisa tetap ter‐apply sampai upstream Filament benar-benar memperbaiki bug ini.
Ini adalah praktik standard untuk hotfix sementara sebelum perbaikan resmi dirilis.
📌 Dokumentasi error kompatibilitas Filament 2 → Filament 3
Ada issue resmi yang dibuat oleh pengguna Filament sendiri di GitHub yang menjelaskan error ini muncul saat upgrade dari Filament v2 ke v3, dengan pesan yang sama seperti yang kamu alami:
👉 Issue #13931 – Upgrade filament v2 to v3 didnt work
Link:
https://github.com/filamentphp/filament/issues/13931
Isi utamanya:
👉 Ini menunjukkan bahwa masalah ini memang kompatibilitas terkait perubahan internal Filament antara v2 dan v3
Untuk isu:
Cara replikasi
composer installpatch akan otomatis diterapkan tanpa perlu manual edit. Tidak ada error lagi di Filament Forms.