Improvements to caching, trimming, thumbnails, and more#5920
Merged
Improvements to caching, trimming, thumbnails, and more#5920
Conversation
- New caching defaults (0.5 play ahead cache, 768 MB limit, 900 frames max) - Seek playhead to trim position after trimming is done, and refresh preview only one time (more stable preview after trimming)
…mmediately after clip is trimmed.
…nail slots, less flicker, better handling of tiny clip widths). This applies improvements to all thumbnail styles (start, start/end, entire clip).
…uring an export caused an error)
…le assets when they were already copied.
Member
Author
…mode "reader" attribute in a clip (which happened to break while testing these changes)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to OpenShot/libopenshot#1032
Lots of good fixes in this PR: