Fix Play/Pause button state when playback reaches end of timeline#5926
Merged
Fix Play/Pause button state when playback reaches end of timeline#5926
Conversation
…m appearing. Not sure when this broke, but this feels like a merge regression.
… easier to read (instead of the real file name of the emoji SVG file)
…eline keyframe panel. - Remove / Reorder track buttons on Experimental timeline (Lock, Keyframe Panel) - Improve selection box on keyframe panel, so the tiny gaps between the property rows do not unselect the clip.
…ormal track style and border style). - Moving thumbnails downward on Experimental timeline (Humanity Dark and Retro themes) - Adding lock functionality to Experimental Timeline (undraggable, undeletable)
…ross Humanity Dark/Retro - add Humanity Dark-only track/clip top overlays and rounded track-name corner parity with JS timeline - fix rounded corner border rendering artifacts in track names - add grouped QWidget timeline theme variable dump logging for parser migration work - bottom-anchor track toolbar icons to base track row (stable with keyframe panel expansion) - add Retro and Humanity Dark-specific lock/keyframe-panel icon assets with improved contrast - improve keyframe panel rows/curves/points for Humanity Dark and Retro (banded rows, no row borders) - refine keyframe panel point selection visibility: stronger selected borders and theme-aware border colors
…rag, snap, tracks, and multi-clip edits - Keep panel icons and top keyframe markers aligned during live drag/snap (including origin snap). - Fix stale panel painting/caching during clip drag. - Correct panel show/hide/move behavior and track height updates when dragging clips across tracks. - Scope keyframe selection/drag to the correct clip/effect/transition to remove cross-clip cross-talk. - Fix add-keyframe to target the selected clip under the playhead, even when that clip lacks the property curve. - Make Delete remove selected keyframes first, then delete clips/transitions on subsequent Delete.
- Match transition opacity to web backend (0.75 unselected, 1.0 selected)\n- Keep drag-created clip/transition previews topmost during initial create-drag\n- Update transition keyframe marker positions live while resizing (not only on mouse-up)\n- Clean preview-override lifecycle for no-move resize exits
…get experimental timeline backends, by overlapping 2 clips.
- Auto-name unnamed split clips with compact start/end time ranges - Trim unneeded leading time units in split clip names - Fix Export Files split-clip rendering to honor start/end frame ranges - Correct clip frame counting and export loop bounds - Start export immediately after folder selection (remove redundant Export click) - Fix file-copy destination existence check in export dialog - Show modified/display file names in file thumbnail tooltips
- Use robust play-mode checks for play/ff/rewind (PLAYBACK_PLAY + non-zero speed). - Skip refreshFrame() seeks during active playback to avoid UI/selection refresh perturbing frame progression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix playback state checks and refresh behavior (related to OpenShot/libopenshot#1036)