-
Notifications
You must be signed in to change notification settings - Fork 46
Motion/election: required majority #5614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The blue "two-third icon" should not be there! |
For use of position 'absolute'.
|
I have worked on this so far. See the issue for questions/notices. |
client/src/app/site/pages/meetings/modules/poll/components/chart/chart.component.html
Outdated
Show resolved
Hide resolved
...ngs/modules/poll/components/single-option-chart-table/single-option-chart-table.component.ts
Outdated
Show resolved
Hide resolved
client/src/app/site/pages/meetings/modules/poll/services/poll.service/poll.service.ts
Outdated
Show resolved
Hide resolved
...t-poll/components/assignment-poll-detail-content/assignment-poll-detail-content.component.ts
Outdated
Show resolved
Hide resolved
...t-poll/components/assignment-poll-detail-content/assignment-poll-detail-content.component.ts
Outdated
Show resolved
Hide resolved
...t-poll/components/assignment-poll-detail-content/assignment-poll-detail-content.component.ts
Outdated
Show resolved
Hide resolved
...es/motion-poll/components/motion-poll-detail-content/motion-poll-detail-content.component.ts
Show resolved
Hide resolved
|
@luisa-beerboom I worked on the CR, see above. Please review again. |
luisa-beerboom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good so far
bspekker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The marking of majorities look good so far. A few qestions/issues came up:
- In the dropdown-menu in the dialogue please change the order of majorities to this: no majority, absolute majority, two-thirds
- The calculation of absolute majority is correct. As discussed with @emanuelschuetze , the two-thirds majority should already be reached if exactly two-thirds or more yes votes were cast.
- Is it possible to include helptexts to the majority options in the dialogue? If so, for absolute majority it should be something like "Indicates if a majority of more than 50% was reached, dependent on the 100%-base" and for two-thirds "Indicates of majority of two-thirds or more was reaches, dependent on the 100%-base"
- When 100%-base "deactivated" is selected, the chart always has the x in the middle even if a majority would be reached, i.e. 100% yes votes. For this 100%-base the chart should never show the majority.
- I observed that the majorities don't work in assignment polls with the voting method "no per candidate". Is that intentional? I think it's okay but want to make sure it's not an oversight.




Resolve #5420