Skip to content

Conversation

@reiterl
Copy link
Member

@reiterl reiterl commented Nov 19, 2025

Resolve #5420

@reiterl reiterl added this to the 4.3 milestone Nov 19, 2025
@reiterl reiterl self-assigned this Nov 19, 2025
@reiterl reiterl added feature Zeeman projectname Röntgen projectname labels Nov 19, 2025
@Elblinator
Copy link
Member

Mock-ups for a finished poll:
(notes)

  • "Required votes' Below valid votes
  • the number should be calculated from the client and then below the number from valid votes
  • the number should be a rounded up whole number
  • If you look at the poll detail there should be required majorities if a majoprity otehr than none is selected ^2

candidate list:
Image

motion poll or one candidate

Image Image

^2
Image

@Elblinator
Copy link
Member

The blue "two-third icon" should not be there!
That is a remnant from an old proposal

@reiterl reiterl marked this pull request as ready for review December 4, 2025 13:55
@reiterl reiterl assigned luisa-beerboom and MSoeb and unassigned reiterl Dec 4, 2025
@reiterl
Copy link
Member Author

reiterl commented Dec 4, 2025

I have worked on this so far. See the issue for questions/notices.
Please look at my progress so far. (it needs updated backend and autoupdate service)

@emanuelschuetze emanuelschuetze requested review from emanuelschuetze and removed request for MSoeb December 8, 2025 13:12
@bspekker bspekker added the waiting Waiting for some other PR/feature; more details in comments label Dec 8, 2025
@reiterl reiterl assigned luisa-beerboom and unassigned reiterl Dec 15, 2025
@reiterl
Copy link
Member Author

reiterl commented Dec 15, 2025

@luisa-beerboom I worked on the CR, see above. Please review again.

Copy link
Member

@luisa-beerboom luisa-beerboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good so far

Copy link

@bspekker bspekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The marking of majorities look good so far. A few qestions/issues came up:

  • In the dropdown-menu in the dialogue please change the order of majorities to this: no majority, absolute majority, two-thirds
  • The calculation of absolute majority is correct. As discussed with @emanuelschuetze , the two-thirds majority should already be reached if exactly two-thirds or more yes votes were cast.
  • Is it possible to include helptexts to the majority options in the dialogue? If so, for absolute majority it should be something like "Indicates if a majority of more than 50% was reached, dependent on the 100%-base" and for two-thirds "Indicates of majority of two-thirds or more was reaches, dependent on the 100%-base"
  • When 100%-base "deactivated" is selected, the chart always has the x in the middle even if a majority would be reached, i.e. 100% yes votes. For this 100%-base the chart should never show the majority.
  • I observed that the majorities don't work in assignment polls with the voting method "no per candidate". Is that intentional? I think it's okay but want to make sure it's not an oversight.

@bspekker bspekker assigned reiterl and unassigned emanuelschuetze and bspekker Dec 17, 2025
@bspekker bspekker removed the waiting Waiting for some other PR/feature; more details in comments label Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Röntgen projectname Zeeman projectname

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Motions/Elections: Required majorities

6 participants