Skip to content

Conversation

@ClJarvis
Copy link
Contributor

@ClJarvis ClJarvis commented Sep 13, 2025

Description

Feat: Added a pizza event to pizza facts for open issue #36.

What type of PR is this? (check all applicable)

  • [ X] ☝️ Add a pizza fact or trivia
  • 🧑‍🍳 Add a pizza recipe
  • 🗺️ Add a regional pizza
  • 🍴 Add a traditional food
  • 📝 Documentation Update

Related Tickets & Documents

Relates to #36

Added to documentation?

  • 📜 README.md
  • [ X] 🙅 no documentation needed

[optional] What GIF best describes this PR or how it makes you feel?

This PR makes me hungry.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

Copy link
Collaborator

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ClJarvis,
Thank you for your contribution! ✨

I've left a review here for you to fix.

Another thing is please address the bot warnings until all check pass.

For linked issue, you can write: Relates to #<issue-number>.

Let me know when they're fixed and ready for a review.
Thank you. 🙂

@ClJarvis ClJarvis changed the title new event added to pizza facts Relates to issue 36 Sep 15, 2025
@ClJarvis ClJarvis changed the title Relates to issue 36 feat: adds a pizza fact Sep 15, 2025
Copy link
Collaborator

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ClJarvis thank you for the fix!
There's still one more punctuation that needs to be fixed here.

You also have one bot warning to address.

In the "Related Tickets & Documents" section of your PR, you should write Relates to #36. Don't add anything else here to pass the check.

@ClJarvis
Copy link
Contributor Author

It still says "all checks have passed, 1 skipped, 2 successful checks."
The welcome check was skipped. How do I get it to run and pass?

@adiati98
Copy link
Collaborator

@ClJarvis you can skip the welcome check. The one that you need to address is this one: #116 (review)

Please read my previous comment to fix it. 👍🏼

Copy link
Collaborator

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done and thank you for your contribution, @ClJarvis! ✨

git merge GIF

@adiati98 adiati98 merged commit 61af3ad into OpenSource-Communities:main Sep 17, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants