Move generic containers into core/containers#693
Open
Spartan322 wants to merge 1 commit intomasterfrom
Open
Conversation
Move tracked allocating containers to memory namespace
Spartan322
force-pushed
the
refactor/containers
branch
from
cd7889e to
f284c42
Compare
wvpm
reviewed
Jan 21, 2026
wvpm
reviewed
Jan 21, 2026
wvpm
previously requested changes
Jan 21, 2026
Contributor
wvpm
left a comment
wvpm
left a comment
There was a problem hiding this comment.
Prefixing commonly used types with memory:: hurts code.
If you want to bring your own allocator, you'd be better off using _detail::T<MyAllocator>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move tracked allocating containers to memory namespace
HasIdentifier.hppwill be split into distinct class headers after merge following #625, done to focus on changing the namespace and headers and minimize refactoring header inclusions in this PR.