Conversation
wvpm
reviewed
Feb 7, 2026
wvpm
reviewed
Feb 7, 2026
wvpm
reviewed
Feb 7, 2026
wvpm
requested changes
Feb 7, 2026
Contributor
wvpm
left a comment
wvpm
left a comment
There was a problem hiding this comment.
Apart from the memory stuff it looks great.
Nice job on your first PR!
wvpm
approved these changes
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When parsing an inventions limit block, keys corresponding to a specific technology are now collected into a list of strings. Once parsing completes,
InventionManager::generate_invention_linksis called fromDataloader.cpp. This step resolves the string identifiers into actual Technology objects, and subsequently populates their newinventionsattribute.I am really not sure if this is the cleanest and most performant way to do this, so a review would be appreciated.
This is in preparation for adding inventions to the Technology Menu, where we need to be able to access a technologies inventions.