Skip to content

Comments

🔄 synced file(s) with OrrisTech/.github#3

Merged
iamzifei merged 1 commit intomainfrom
repo-sync/github/default
Feb 20, 2026
Merged

🔄 synced file(s) with OrrisTech/.github#3
iamzifei merged 1 commit intomainfrom
repo-sync/github/default

Conversation

@iamzifei
Copy link

@iamzifei iamzifei commented Feb 20, 2026

synced local file(s) with OrrisTech/.github.

This PR was automatically created by the org file sync workflow. It syncs the latest org standard files from the .github repo. Review the changes and merge when ready.

Changed files
  • synced local .github/workflows/ci.yml with remote sync/.github/workflows/ci.yml

This PR was created automatically by the repo-file-sync-action workflow run #22212195514

Copilot AI review requested due to automatic review settings February 20, 2026 05:11
@github-actions
Copy link

React Doctor Report

Click to expand results
npm warn exec The following package was not found and will be installed: react-doctor@0.0.28
react-doctor v0.0.28

�[2mScanning /home/runner/work/clawra/clawra...�[22m


�[31mSomething went wrong. Please check the error below for more details.�[39m
�[31mIf the problem persists, please open an issue on GitHub.�[39m
�[31m�[39m
�[31mNo React dependency found in package.json�[39m

Powered by react-doctor

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Syncs this repo’s CI caller workflow with the org-standard version from OrrisTech/.github, adjusting how advisory jobs are configured.

Changes:

  • Removed continue-on-error: true from the lint-typecheck job.
  • Removed continue-on-error: true from the security job.
  • Updated comments describing why these jobs “won’t block CI”.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 25 to 28
name: Lint & Type Check
# Advisory only — does not block build or other jobs.
# Remove continue-on-error once repo lint errors are resolved.
continue-on-error: true
# No "needs:" from other jobs, so failures here won't block CI.
uses: OrrisTech/.github/.github/workflows/ci-lint-typecheck.yml@main
Copy link

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

continue-on-error: true was removed, so this job is no longer “advisory only”; a failure will mark the workflow/check run as failed and may block merges if the check is required. Either restore continue-on-error: true (if it should be advisory) or update the surrounding comments to reflect the new blocking behavior and remove the “advisory” wording.

Copilot uses AI. Check for mistakes.
name: Security Audit
# Advisory only — does not block other jobs.
continue-on-error: true
# No "needs:" from other jobs, so failures here won't block CI.
Copy link

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue here: with continue-on-error removed, this Security Audit job isn’t “advisory only” anymore—its failure will fail the workflow/check run and can block merges depending on required checks. Either re-add continue-on-error: true or adjust the comments to match the intended gating behavior.

Suggested change
# No "needs:" from other jobs, so failures here won't block CI.
# No "needs:" from other jobs, so failures here won't block CI.
continue-on-error: true

Copilot uses AI. Check for mistakes.
@iamzifei iamzifei merged commit f9e56d9 into main Feb 20, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant