Conversation
285bc1c to
1d9e000
Compare
React Doctor ReportClick to expand results
|
There was a problem hiding this comment.
Pull request overview
Syncs this repo’s CI caller workflow with the org-standard version from OrrisTech/.github, adjusting how advisory jobs are configured.
Changes:
- Removed
continue-on-error: truefrom thelint-typecheckjob. - Removed
continue-on-error: truefrom thesecurityjob. - Updated comments describing why these jobs “won’t block CI”.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| name: Lint & Type Check | ||
| # Advisory only — does not block build or other jobs. | ||
| # Remove continue-on-error once repo lint errors are resolved. | ||
| continue-on-error: true | ||
| # No "needs:" from other jobs, so failures here won't block CI. | ||
| uses: OrrisTech/.github/.github/workflows/ci-lint-typecheck.yml@main |
There was a problem hiding this comment.
continue-on-error: true was removed, so this job is no longer “advisory only”; a failure will mark the workflow/check run as failed and may block merges if the check is required. Either restore continue-on-error: true (if it should be advisory) or update the surrounding comments to reflect the new blocking behavior and remove the “advisory” wording.
| name: Security Audit | ||
| # Advisory only — does not block other jobs. | ||
| continue-on-error: true | ||
| # No "needs:" from other jobs, so failures here won't block CI. |
There was a problem hiding this comment.
Same issue here: with continue-on-error removed, this Security Audit job isn’t “advisory only” anymore—its failure will fail the workflow/check run and can block merges depending on required checks. Either re-add continue-on-error: true or adjust the comments to match the intended gating behavior.
| # No "needs:" from other jobs, so failures here won't block CI. | |
| # No "needs:" from other jobs, so failures here won't block CI. | |
| continue-on-error: true |
synced local file(s) with OrrisTech/.github.
This PR was automatically created by the org file sync workflow. It syncs the latest org standard files from the .github repo. Review the changes and merge when ready.
Changed files
.github/workflows/ci.ymlwith remotesync/.github/workflows/ci.ymlThis PR was created automatically by the repo-file-sync-action workflow run #22212195514