-
Notifications
You must be signed in to change notification settings - Fork 0
Fix inconsistent array schema definition in boolean_argument_flag config #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement BooleanArgumentFlag rule to detect boolean parameters indicating multiple responsibilities. - Introduce configuration options for ignored classes and ignore patterns. - Update README with new rule documentation. - Add tests for various scenarios including ignored classes and patterns. Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
…curacy Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
…and accuracy in error message line numbers Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
… include invalid regex configuration Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
…entFlag documentation Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…red_in_classes Co-authored-by: Orrison <6799341+Orrison@users.noreply.github.com>
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Address feedback on BooleanArgumentFlag rule and configurations PR
Fix inconsistent array schema definition in boolean_argument_flag config
Nov 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses feedback from PR #91 regarding inconsistent schema type usage in
config/extension.neon.Changes
ignored_in_classesparameter fromlistOf(string())toarrayOf(string())on line 64This aligns with the established pattern used by all other array parameters in the extension configuration (e.g.,
exceptions,subtract_prefixes,ignored_when_in_classes).💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.