Skip to content

Conversation

@XxX-Daniil-underscore-Zaikin-XxX
Copy link
Contributor

@XxX-Daniil-underscore-Zaikin-XxX XxX-Daniil-underscore-Zaikin-XxX commented Jun 18, 2024

I've encountered a couple of issues when trying to use PPJ files. This is an attempt to fix them.

So far, this PR:

  • Fixes import directories being treated as files
  • Fixes crash when source files have lines shorter than 9 chars before scriptname declaration
  • Changes the default value of the skyrim-allow-unknown-event... option to align with the other Strict checks (i.e. disabled by default).
  • Allows some keywords to be used as function parameters, with the proper strict check. Can be extended to do more.

@XxX-Daniil-underscore-Zaikin-XxX XxX-Daniil-underscore-Zaikin-XxX marked this pull request as draft June 19, 2024 06:22
@XxX-Daniil-underscore-Zaikin-XxX
Copy link
Contributor Author

I think this PR is pretty much done. If I find anything else to change, I can probably just make another one.

@XxX-Daniil-underscore-Zaikin-XxX XxX-Daniil-underscore-Zaikin-XxX marked this pull request as ready for review June 4, 2025 11:00
@XxX-Daniil-underscore-Zaikin-XxX XxX-Daniil-underscore-Zaikin-XxX marked this pull request as draft June 4, 2025 11:15
@XxX-Daniil-underscore-Zaikin-XxX
Copy link
Contributor Author

never mind, I have yet to make sure GH actions works.

@XxX-Daniil-underscore-Zaikin-XxX
Copy link
Contributor Author

never mind? Looks like CI just worked first try.

@XxX-Daniil-underscore-Zaikin-XxX XxX-Daniil-underscore-Zaikin-XxX marked this pull request as ready for review June 4, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant