Fix epoch stake seeding, add reward burn accounting, consolidate CLI #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Startup was populating block.EpochStakesPerVoteAcct and TotalEpochStake from raw delegation.StakeLamports sums, which can differ from epoch-effective stakes when delegations are warming up or cooling down. The correct values were already loaded into global.EpochStakes() by buildInitialEpochStakesCache() but weren't being used. This seeds from the epoch stakes cache instead, matching Agave's get_epoch_stake syscall behavior and the existing epoch boundary code path. Also removes dead SetVoteStakeTotals (written but never read). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
7layermagik
force-pushed
the
fix/startup-epoch-stake-seeding
branch
from
d1c1f4e to
aa8adfd
Compare
smcio
approved these changes
Feb 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Two commits addressing correctness in epoch stake seeding and reward distribution.
1. Fix startup epoch stake seeding (
9fb3668)At startup,
setupInitialVoteAcctsAndStakeAccts()was seedingEpochStakesPerVoteAcctandTotalEpochStakeusing rawdelegation.StakeLamportsfrom the AccountsDB scan. This is incorrect — epoch-effective stakes have warmup/cooldown applied viaDelegation.Stake(epoch, stakeHistory), and the manifest already stores these correctly.Changes:
global.EpochStakes(block.Epoch)from the epoch stakes cache (loaded bybuildInitialEpochStakesCache()from the manifest)SetVoteStakeTotals(),voteStakeTotalsfield,voteStakeTotalsMumutex inGlobalCtxFiles:
pkg/replay/block.go,pkg/global/global_ctx.go2. Add reward burn accounting (
aa8adfd)Mithril's reward distribution path previously panicked on per-record account-level failures during stake reward payout. Agave and Firedancer instead treat these as "burned" rewards — the sysvar advances by
distributed + burned, but capitalization only increases bydistributed. This is consensus-critical accounting.Changes:
DistributeStakingRewardsFromSpoolnow returns(distributedLamports, burnedLamports)ErrNoAccountfromGetAccount→ burn (AgaveAccountNotFound)fd_stake_get_state != 0)!fd_stake_state_v2_is_stake)ArithmeticOverflow)UnableToSetState)ErrNoAccountGetAccount errors (IO/storage corruption) still panic — these should not be silently burnedEpochRewards.Distribute(distributed + burned),Capitalization += distributedStoreAccountsto exclude burned recordsFiles:
pkg/rewards/rewards.go,pkg/replay/rewards.go🤖 Generated with Claude Code