Add snapshot crash safety and consolidate run command #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nge and verify-live Allows bounded replay in run mode with all production features (modern bootstrap, cluster safety, file logging, genesis validation). Removes verify-range and verify-live commands — run mode now covers all functionality via --end-slot / --num-slots. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Downloads now write to .partial files first, then atomically rename on successful completion. This prevents corrupted snapshots from crashes mid-download being treated as valid on the next run. - Write to .partial suffix during HTTP downloads - FinalizePartialDownload() atomically renames after success - CleanupPartialDownload() removes partials on error/cancellation - Skip .partial files in detectExistingSnapshots() - Clean .partial files in CleanSnapshotDownloadDir() on startup Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
palmerlao
approved these changes
Feb 8, 2026
Collaborator
palmerlao
left a comment
palmerlao
left a comment
There was a problem hiding this comment.
I haven't tested it but LGTM
| name := entry.Name() | ||
|
|
||
| // Skip partial downloads (incomplete files from crashed runs) | ||
| if strings.HasSuffix(name, ".partial") { |
Collaborator
There was a problem hiding this comment.
if strings.HasSuffix(name, snapshot.PartialSuffix) {?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
08b63d8— Add --end-slot and --num-slots flags to mithril run, remove verify-range and verify-live:runnow supports bounded replay via--end-slot/--num-slots, makingverify-rangeandverify-liveredundant. Both commands removed along with their dedicated config fields (load_from_snapshot,load_from_accounts_db). Config bindings forreplay.num_slotsandreplay.end_slotalready existed in the sharedinitConfigAndBindFlags, so TOML config works automatically.175ff12— Add crash safety for snapshot downloads with .partial suffix: HTTP snapshot downloads now write to<filename>.partialfirst, then atomicallyos.Renameto the final path only after the entire tar stream is successfully processed. Prevents a crash mid-download from leaving a corrupted snapshot that the next run would treat as valid.CleanSnapshotDownloadDirremoves leftover.partialfiles on startup, anddetectExistingSnapshotsskips them.🤖 Generated with Claude Code