Ensure buildings are visible at all zoom levels#209
Open
charliemcgrady wants to merge 3 commits intomainfrom
Open
Ensure buildings are visible at all zoom levels#209charliemcgrady wants to merge 3 commits intomainfrom
charliemcgrady wants to merge 3 commits intomainfrom
Conversation
charliemcgrady
force-pushed
the
missing_sfo_buildings
branch
from
fa31bef to
cf50240
Compare
charliemcgrady
force-pushed
the
missing_sfo_buildings
branch
from
cf50240 to
3756d90
Compare
Contributor
Author
|
Screenshot at high zoom levels: |
Contributor
Author
|
Confirmed the above change causes rendering defects for rendering overlapping extrusion layers for buildings and building parts: |
Contributor
Author
|
Added 0974ec8 to handle the above rendering defects. Now, building outlines are rendered as outline layers when the Did my best to keep the style consistent: One caveat to this approach is the buildings switch back to being extrusion layers at low zooms because the |
charliemcgrady
requested review from
jonahadkins
and removed request for
jonahadkins
charliemcgrady
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before Fix
After Fix