Conversation
philpax
reviewed
Feb 4, 2026
Contributor
There was a problem hiding this comment.
Code seems reasonable.
Only thing that I'm unsure about: ensure we run the safetychecker before giving the image to the WM, if you aren't already; you don't want someone to modify the safety cache or swap in an image after it's already been checked. You can keep an in-memory cache for seeds (by hash?) to make this a bit less painful for revisiting the same seed.
Oh, and fix the CI, but that's a given
Contributor
|
Note to self before merge: disable W8A8 quant, we're not supposed to run the model with a quant |
Collaborator
Author
|
Fixes #19 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15 and #10.
Implements nsfw seed checker with https://huggingface.co/Freepik/nsfw_image_detector.
Also includes a restructure to server-components to run as a single unified server on port 7987: server.py (bridge), world_engine.py (generation), safety.py (NSFW detection)
Previous implementation was some hybrid client-server setup that had client managing the seed directory. The new implementation now allocates seed directory, safety checking and seed image integrity verification on server side. Having the safety checks be performed server side also ensures that if the server is hosted on separate device as the client, the safeties and generations are still authorised by the server process.
Current behaviour is that unsafe files hidden from UI (not deleted) and warns user about hidden files.