Open
Conversation
14ebe73 to
c2b35e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OWL Control can occasionally fail to overwrite its own metadata during validation:
As a follow-up fix to @Clydingus's rename workaround, this uses a different filename for the initial metadata, so that we are less likely to encounter a write-lock of any kind when writing the validated file out. This will also check for existing
metadata.jsonfiles to ensure that previous versions can still be uploaded.I'm not merging this in yet as I haven't fully tested it yet, but it should be pretty easy to land in a patch release.