-
Notifications
You must be signed in to change notification settings - Fork 1
feat[bench]: stronger benchmarking scripts #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er as a build dependency
…benchmarks and remove deprecated scripts - Introduced a new benchmark tier system with options for smoke, standard, and stress tests. - Updated performance testing workflow to utilize the new tier system. - Removed obsolete load testing scripts and associated files to streamline the benchmarking process. - Enhanced documentation in the performance tests to reflect the new structure and usage.
…and tile request validation - Removed dead code and improved the SlideInfo struct. - Added minimum latency sample requirement for tile requests. - Implemented latency tracking for cursor and viewport acknowledgments in WebSocket communication. - Updated HTTP request handling to validate tile and overlay requests based on slide dimensions. - Enhanced output formatting to include overlay latency metrics in stress test results.
…ving obsolete tests - Removed the fanout and overlay scenarios to simplify the testing framework. - Updated the comprehensive stress scenario to cover all essential paths, including WebSocket broadcasts and HTTP requests. - Enhanced documentation to reflect the new structure and usage of load testing scenarios.
…mparison features - Introduced a new `BenchmarkRunner` to manage warm-up phases and multiple iterations for performance tests. - Updated existing benchmarks to utilize the new runner, improving statistical significance and regression detection. - Added baseline management for comparison against previous results, enhancing the ability to track performance regressions. - Improved documentation for benchmark tests, detailing the new features and usage.
- Removed unused fields from `BenchmarkResult` to streamline benchmark results. - Cleaned up `ComprehensiveEvent` by eliminating dead code related to WebSocket events. - Enhanced the handling of WebSocket acknowledgments in the comprehensive stress scenario for improved clarity and performance.
…gement and streamlined execution - Enhanced performance testing documentation to include new benchmark iterations and warm-up procedures. - Introduced a new baseline storage system for benchmark results, allowing automatic regression detection. - Updated testing commands for smoke, standard, and stress tests to improve clarity and execution flow. - Added a new baseline JSON file to store benchmark results for future comparisons.
- Added a Clippy allowance for print literal in the `print_comparison` method of the `BenchmarkRunner` to enhance code clarity and maintainability.
- Eliminated the unused `error` import from the `tracing` crate in the session manager file to clean up the code and improve clarity.
…ario - Replaced modulo operations with `is_multiple_of` for better readability and clarity in tile calculations. - Updated the logic for determining tissue tiles to enhance code maintainability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.