Skip to content

Conversation

@JanosJiri
Copy link
Collaborator

Adding some notice blocks, citation and fixing typos.

Adding some notice blocks, citation and fixing typos.
@JanosJiri JanosJiri self-assigned this Aug 5, 2025
@JanosJiri JanosJiri added the documentation Improvements or additions to documentation label Aug 5, 2025
@JanosJiri
Copy link
Collaborator Author

I've added a few notice blocks to highlight some parts. The style of notice blocks seems great to attract the reader's attention. However, I don't have any strong opinion on them. I also fixed a few typos and added a citation block. Maybe the citation block should come sooner in the README to make sure people know how to cite properly. Finally, I used double $ for equations as this seems to work on PyPI. @danielhollas, could you have a look a see what you think about these changes?

@JanosJiri JanosJiri requested a review from danielhollas August 5, 2025 09:44
Add JPCL citation
@JanosJiri
Copy link
Collaborator Author

I was also exploring the option to add the paper to the CITATION.cff but I'm not convinced this is the best option.

Copy link
Collaborator

@danielhollas danielhollas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I am a big fan of these, I agree the "alerts" or admonitions make for a nice visual emphasis and we should use them more.

The original way was the best; I couldn't find a good way how to display inline maths on PyPI. Single $ doesn't work and $$ puts everything on a new line. Suggestions I found propose to use Unicode characters but this won't make it the same as equations. Anyways, it's important if it displays correctly on GitHub, not PyPI. 

(Side note, maybe the documentation could move to Github Wiki?)
@JanosJiri JanosJiri merged commit 7522f6d into main Aug 6, 2025
2 checks passed
@JanosJiri JanosJiri deleted the readme-patch branch August 6, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants