add focal, remove indigo/lunar to .travis.yml #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v4hn
reviewed
Aug 10, 2020
Member
v4hn
left a comment
v4hn
left a comment
There was a problem hiding this comment.
I'm unsure about the SDFormat include. The rest looks good.
pr2_gazebo_plugins/CMakeLists.txt
Outdated
|
|
||
| # Depend on system install of Gazebo and SDFormat | ||
| find_package(gazebo REQUIRED) | ||
| pkg_check_modules(SDF sdformat REQUIRED) |
Member
There was a problem hiding this comment.
The package still uses sdformat, relying on the SDFormat include.
Does Gazebo add the header include or why do you just remove it here? Should we switch to a find_package (which SDFormat provides for years by now)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.