feat: thread participation tracking for Slack#2
Open
Utkarshbhimte wants to merge 20 commits intomainfrom
Open
Conversation
When the bot replies in a Slack thread it didn't start, it now tracks that thread. Future messages in tracked threads are treated as implicit mentions, so the bot continues participating in conversations it joined. Changes: - context.ts: Added participatedThreads Set with record/check methods - prepare.ts: Extended implicitMention to check thread participation - dispatch.ts: Records thread participation after delivering replies
- Wrap threadTs with String() in dispatch.ts to handle number type from MessageThreadId - Remove participatedThreads Set from public SlackMonitorContext type (accessor functions are sufficient)
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds thread participation tracking so the bot processes replies in threads it has participated in (not just threads it started).
Changes
src/slack/monitor/context.ts: AddedparticipatedThreads: Set<string>,recordThreadParticipation(), andhasParticipatedInThread()src/slack/monitor/message-handler/prepare.ts: UpdatedimplicitMentionto checkctx.hasParticipatedInThread()This fixes the issue where the bot would miss replies in threads it joined but didn't start.