Conversation
Group DMs (MPIMs) were not being handled consistently with other conversation types, causing several issues: - No auth gating: group DM senders bypassed allowFrom checks - No mention requirement: every message was processed without requiring a mention, causing unnecessary bot responses - No channel config: group DMs couldn't use per-channel settings like systemPrompt, requireMention, or user allowlists - Wrong labels: group DMs showed as 'Slack message in #channel' instead of 'Slack group DM in #channel' - Wrong ChatType: group DMs were classified as 'channel' instead of 'group', affecting session routing Changes: - prepare.ts: Extended channelConfig resolution to include group DMs (isRoomish instead of isRoom) - prepare.ts: Added allowFrom auth gating for group DM senders - prepare.ts: Applied mention gating and user allowlists to group DMs - prepare.ts: Fixed inbound labels and ChatType for group DMs
- Remove redundant groupDmEnabled check (already enforced by isChannelAllowed) - Revert isGroup to isRoom for ack reaction gating to avoid widening scope for group DMs under group-all
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes group DM (MPIM) message handling in Slack.
Ensures group DMs are properly routed and processed by the bot.