Open
Conversation
aravindsiv
requested changes
Mar 29, 2024
Contributor
aravindsiv
left a comment
aravindsiv
left a comment
There was a problem hiding this comment.
Only minor comment so we are agreed on the plant estimator logic.
Otherwise, I'm guessing the params are all good since we have seen it work.
|
|
||
| </node> | ||
|
|
||
| <!-- Plant estimator --> |
Contributor
There was a problem hiding this comment.
Nit: commented out logic that we probably don't need since we are modifying the plant estimator to just get the pose from the markers for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Machine-specific launch and config files