support parallel for infgcn #220
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ppmat-bot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Thanks for your contribution! |
| sampler: | ||
| __class_name__: BatchSampler | ||
| __init_params__: | ||
| shuffle: False |
Collaborator
There was a problem hiding this comment.
所有新增的配置文件的shuffle都设置为False ?
| "by_num_atoms", | ||
| "by_dataloader", | ||
| "compute_metric", | ||
| "compute_metric_SUN", |
Collaborator
There was a problem hiding this comment.
这个字段和上面的compute_metric含义上是重复的，可以考虑统一使用compute_metric管理
| from ppmat.models import build_model_from_name | ||
| from ppmat.utils import logger | ||
| from ppmat.utils import save_load | ||
| except Exception as exc: # noqa: BLE001 |
Collaborator
There was a problem hiding this comment.
为啥都需要try-except包起来？
Collaborator
|
另外，建议后续提PR按照实现的任务多次commit，尽量避免所有改动都集中到一个commit里面 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.