refactor(observable): refactor observable types and keys for consistency #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
PakitoSec
commented
Jan 14, 2026
PakitoSec
commented
- Updated observable types from "ipv4-addr" to "ipv4", "domain-name" to "domain", and "email-addr" to "email" across various files including documentation, JavaScript code, and tests.
- Adjusted key generation functions to reflect the new observable types.
- Modified icon mapping in the visualization package to use the updated observable types.
- Ensured all related tests were updated to match the new observable type definitions and keys.
- Updated observable types from "ipv4-addr" to "ipv4", "domain-name" to "domain", and "email-addr" to "email" across various files including documentation, JavaScript code, and tests. - Adjusted key generation functions to reflect the new observable types. - Modified icon mapping in the visualization package to use the updated observable types. - Ensured all related tests were updated to match the new observable type definitions and keys.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.