Implement scan timeout and soft fail configuration#73
Open
fabiano-amaral wants to merge 2 commits intoPaloAltoNetworks:mainfrom
Open
Implement scan timeout and soft fail configuration#73fabiano-amaral wants to merge 2 commits intoPaloAltoNetworks:mainfrom
fabiano-amaral wants to merge 2 commits intoPaloAltoNetworks:mainfrom
Conversation
Author
|
Hey @sgordon46 , Could you review this pull request? I couldn’t find a clear contribution guide in the repository, but if there’s any adjustment that needs to be made, just let me know and I’ll take care of it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces timeout management for the Prisma Cloud Scan action. It adds two new optional inputs:
The implementation uses Promise.race to enforce the time limit on the twistcli execution. If on_timeout is set to success, the action will log a warning and exit gracefully without generating result files, ensuring the pipeline continues even if the scan takes too long.
##Motivation and Context
In some CI/CD environments, scan operations might hang or take unexpectedly long, causing pipelines to stall. This change allows users to:
How Has This Been Tested?
Screenshots (if appropriate)
N/A
Types of changes
Checklist