Open
Conversation
Signed-off-by: Vincent Potucek <vpotucek@me.com>
Pankraz76
force-pushed
the
UseVarForPrimitive
branch
from
4a6a115 to
3f4f5b0
Compare
Pankraz76
commented
Dec 22, 2025
| recipeList: | ||
| - org.openrewrite.java.migrate.lang.var.UseVarForGenericsConstructors | ||
| - org.openrewrite.java.migrate.lang.var.UseVarForPrimitive | ||
| - org.openrewrite.staticanalysis.NoDoubleBraceInitialization |
Owner
Author
There was a problem hiding this comment.
Pankraz76
commented
Dec 22, 2025
|
|
||
| AtomicReference<TestExecutionResult> result = new AtomicReference<>(); | ||
| var result = new AtomicReference<TestExecutionResult>(); | ||
| var listener = new TestExecutionListener() { |
Owner
Author
There was a problem hiding this comment.
already having some var pattern. having this fully align, gives the code proper structure.
added 4 commits
December 22, 2025 13:56
Signed-off-by: Vincent Potucek <vpotucek@me.com>
Signed-off-by: Vincent Potucek <vpotucek@me.com>
This was referenced Dec 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
UseVarForPrimitiverelated to:
rewritesupport forerrorprone.refasterrulesjunit-team/junit-framework#5002Kindly asking if this is something to consider for junit?
Might want to apply var style like achieved in:
Also wishing you a wonderful Christmas 🎄
@vlsi @marcphilipp @mpkorstanje
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations