Filp in/out edges for edgeMapReduce dense operations #86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the following
edgeMapDenseimplementation is correct, I thinkedgeMapReduce_denseandedgeMapCount_densefunctions should also flip the in/out edges for the pull operation.gbbs/gbbs/edge_map_data.h
Lines 61 to 63 in ed8b048
I realized this issue because PageRank produced NaN values because of zero-division when some of the vertices have zero out-degree.
However, this should not happen because the contribution of zero out-degree vertices cannot be propagated to other vertices.
Sorry that I did not test its behavior other than PageRank. This fix may cause some inconsistency in other benchmarks.