Rebindable bindonce with 1.3 compatibility and refresh on multiple events#115
Open
jakubdostal wants to merge 7 commits intoPasvaz:rebind-debugfrom
jakubdostal:rebind-debug
Open
Rebindable bindonce with 1.3 compatibility and refresh on multiple events#115jakubdostal wants to merge 7 commits intoPasvaz:rebind-debugfrom jakubdostal:rebind-debug
jakubdostal wants to merge 7 commits intoPasvaz:rebind-debugfrom
jakubdostal:rebind-debug
Conversation
Just cleaning up a few linter warnings/errors and formatting before larger changes.
and learning how refreshOn is implemented to make changes to it.
Fix: - silly error in classBinder - the context of this needs to be maintained in all functions that use the keyword.
- it is possible to refresh on multiple events by including the event names in the refreshOn attr. - refreshOn syntax is now more sensible (the whole attribute is interpreted as a space separated list of event names).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commits should be fairly self explanatory but feel free to ask for clarifications or anything else.