Updated App Structure and Build for Easier Development Workflow#116
Open
DeanPoulin wants to merge 3 commits intoPasvaz:masterfrom
Open
Updated App Structure and Build for Easier Development Workflow#116DeanPoulin wants to merge 3 commits intoPasvaz:masterfrom
DeanPoulin wants to merge 3 commits intoPasvaz:masterfrom
Conversation
added 2 commits
January 30, 2015 14:50
- Added bower dependency on Angular (Should this be 1.x vs 1.2.x?) - Added jshint - Fixed jshint errors in code line 1 col 13 Strings must use singlequote. line 18 col 35 Strings must use singlequote. line 36 col 19 Strings must use singlequote. line 140 col 44 Expected '!==' and instead saw '!='. line 158 col 20 Don't make functions within a loop. line 167 col 26 'ctrl' is already defined. line 204 col 18 Don't make functions within a loop. line 232 col 28 Strings must use singlequote. line 292 col 19 Bad line breaking before '&&'. line 301 col 59 Strings must use singlequote. - Added gulp build with uglify, ngAnnotate, etc... - Added .gitignore - New development workflow: 1) npm install 2) make development changes 3) gulp build 4) tag repository
Owner
|
Nice job, thank you. I'll test and commit it asap |
Author
|
Awesome. This helped us to solve some major performance issues, thanks a million! With this type of build we can break the source into multiple files as well to help with separation of concerns and eventually add some simple tests to validate how the component should work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been doing a lot of front end JS development lately using the gulp build process and I've found it to be really awesome. I noticed you've got some things in here that can be easier accomplished leveraging a gulp type build. You might want to rev this change to be 0.4.0 since the main artifact is located in a different place and I'm sure a lot of developers have the bower dependency specified as 0.3.x.
So here it is:
Some key differences, there's now a dist directory where the deployable artifacts are created via gulp. With the addition of jsHint, it complained about a few things, so I resolved those issues.
Here's what was done: