Remove persistentId ("PayU") from OauthCacheMemcached#67
Open
webdudi wants to merge 1 commit intoPayU-EMEA:masterfrom
Open
Remove persistentId ("PayU") from OauthCacheMemcached#67webdudi wants to merge 1 commit intoPayU-EMEA:masterfrom
webdudi wants to merge 1 commit intoPayU-EMEA:masterfrom
Conversation
webdudi
changed the title
|
This change improves the performance of the library. Why is this not merged into the master? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not namespace or prefix - it's persistent_id.
http://php.net/manual/en/memcached.construct.php
persistent_id
By default the Memcached instances are destroyed at the end of the request. To create an instance that persists between requests, use persistent_id to specify a unique ID for the instance. All instances created with the same persistent_id will share the same connection.
If it's in constructor - the number of current connections to memcached grows rapidly.