Add XGCompiler class #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on devkitppc
StarsMmd
reviewed
Oct 5, 2021
| } | ||
| #endif | ||
|
|
||
| class func replaceRamASM(RAMOffset: Int, newASM asm: [UInt32]) { |
Collaborator
There was a problem hiding this comment.
Do you want to keep this? I think I removed it and switched to the metroworks area in dol as the preference. This could still be useful in future if we end up writing a lot of assembly code. It's region specific though which is the main reason I didn't like it as a solution.
Collaborator
Author
There was a problem hiding this comment.
This is actually just the UInt32 version of the function, they are identical with different return types
| enum Commands { | ||
| case wit | ||
| case wimgt | ||
| case gcc |
Collaborator
There was a problem hiding this comment.
The indentation is a bit funny here but no big deal
| return output | ||
| } | ||
|
|
||
| @discardableResult |
Collaborator
There was a problem hiding this comment.
Did you mean to remove this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on devkitppc