Issue #1744: Some comments on Accelerate LAPACKE integration #2331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove check for ${CMAKE_BINARY_DIR}/lib/liblapacke.3.dylib
Remove copy of liblapacke.3.dylib to ${CMAKE_BINARY_DIR}/lib
github-actions
bot
added
the
external
rturrado
changed the title
Contributor
|
Thanks @rturrado, I'll give it a spin on mac :) I'm not 100% sure but I think the copy was not just for the conditional but so it can be used by the rest of the system, let's see.. |
Contributor
Author
Thanks!
Yes, that could well be. Although, in that case, we might also be better off adjusting the use in those other points so that they go and search at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
This PR addresses @lepus2589 comments from issue 1744.
Description of the Change:
Use
find_package(LAPACKE).Use a tag (v2.0.0) instead of referencin the
masterbranch.Remove check for
EXISTS ${CMAKE_BINARY_DIR}/lib/liblapacke.3.dylibRemove copy of
liblapacke.3.dylibto${CMAKE_BINARY_DIR}/lib.Benefits:
Rely on
find_packageto check if LAPACKE library has to be downloaded.Reference a stable LAPACKE library version.
Remove an unnecessary copy of a dynamic library.
Possible Drawbacks:
This PR has to be tested on Apple/ARM64, which I couldn't do.
Related GitHub Issues:
#1744