Switch from depricated Joomla function

[AndyGaskell]

I found a bug with the code for the latest joomla version.

This seems to stem, I think, from the deprecation of the JFactory::getURI(); function. It should, I think, be changed to the JUri::getInstance(); function.

This bug means the return URL is not correct when saving a new item for the first time.

There is some discussion about JFactory::getURI(); versus JUri::getInstance(); on https://joomla.stackexchange.com/questions/4294/get-the-current-joomla-url I'll try to find some more formal notes or docs about this though.

This seems to only be an issue on Joomla! 3.7.3 and later, also is, I think, only an issue when creating items in the front end.

Sorry, this really needs more details, version info and background, but I thought I'd jot some initial notes anyway, and add more later.

[robations]

As the $uri variable gets overwritten in the following line you can almost certainly delete the JUri::getInstance() line completely.

$uri = JUri::getInstance();
$uri = 'index.php?option=com_content&task=article.edit&a_id='.$id;	                               

The $userId and $button variables in the same block are also unused.

But pretty sure this project is abandonware. Unfortunately I need to update a load of legacy Joomla websites...

[AndyGaskell]

@robations yea, it's rendered obsolete by the inclusion of custom fields in the Joomla core really. Let me know if you need a hand with anything though.

[amitkray]

@robations yea, it's rendered obsolete by the inclusion of custom fields in the Joomla core really. Let me know if you need a hand with anything though.

But I am still unabkle to add custom field in Joomla categories.