Skip to content

Conversation

@maxnorm
Copy link
Collaborator

@maxnorm maxnorm commented Nov 24, 2025

Summary

Changes Made

Checklist

Before submitting this PR, please ensure:

  • Code follows the Solidity feature ban - No inheritance, constructors, modifiers, public/private variables, external library functions, using for directives, or selfdestruct

  • Code follows Design Principles - Readable, uses diamond storage, favors composition over inheritance

  • Code matches the codebase style - Consistent formatting, documentation, and patterns (e.g. ERC20Facet.sol)

  • Code is formatted with forge fmt

  • Existing tests pass - Run tests to be sure existing tests pass.

  • New tests are optional - If you don't provide tests for new functionality or changes then please create a new issue so this can be assigned to someone.

  • All tests pass - Run forge test and ensure everything works

  • Documentation updated - If applicable, update relevant documentation

Make sure to follow the contributing guidelines.

Additional Notes

@netlify
Copy link

netlify bot commented Nov 24, 2025

Deploy Preview for compose-diamonds ready!

Name Link
🔨 Latest commit 454f3a0
🔍 Latest deploy log https://app.netlify.com/projects/compose-diamonds/deploys/69247fc18caa0357ec6e762c
😎 Deploy Preview https://deploy-preview-219--compose-diamonds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

Coverage Report

Coverage

Metric Coverage Details
Lines 84% 1630/1940 lines
Functions 87% 310/358 functions
Branches 70% 230/330 branches

Last updated: Mon, 24 Nov 2025 15:24:14 GMT for commit 454f3a0

@github-actions
Copy link

Gas Report

No gas usage changes detected between main and docs/posthog.

All functions maintain the same gas costs. ✅

Last updated: Mon, 24 Nov 2025 15:24:51 GMT for commit 454f3a0

@maxnorm maxnorm merged commit da56a29 into Perfect-Abstractions:main Nov 24, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant