ParseXS: allow XS files with no XS again #24017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I can confirm that this would fix GH #24016. |
khwilliamson
approved these changes
Dec 20, 2025
Leont
approved these changes
Dec 20, 2025
GH #24016 ParseXS / xsubpp allowed .xs files to contain only C code; i.e. no XS code. A warning was issued about about a missing MODULE line, but the C contents of the file was emitted as-is. My recent refactoring broke this - it was now generating a C code file with zero lines. This was because ParseXS now splits the parsing and code-emitting into two separate phases, and this code during parsing: warn "Didn't find a 'MODULE ... PACKAGE ... PREFIX' line\n"; exit 0; # Not a fatal error for the caller process was now exiting before any lines had been emitted. The fix is to not suddenly exit, but instead continue with pared-down parsing and code emitting.
iabyn
force-pushed
the
davem/xs_no_mod
branch
from
597af47 to
8a0165f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GH #24016
ParseXS / xsubpp allowed .xs files to contain only C code; i.e. no XS code. A warning was issued about about a missing MODULE line, but the C contents of the file was emitted as-is.
My recent refactoring broke this - it was now generating a C code file with zero lines. This was because ParseXS now splits the parsing and code-emitting into two separate phases, and this code during parsing:
was now exiting before any lines had been emitted.
The fix is to not suddenly exit, but instead continue with pared-down parsing and code emitting.