embed.fnc: Add some [SME]PTR asserts to functions missing them #24021
+42
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is documented to handle empty strings, so EPTRge is appropriate.
This handles an empty string, and is called with that currently a lot
It can handle an empty string and is called with empty strings
These can handle empty strings, and are called with them.
These two functions examine their input string without checking if it is zero length. So, the assertion needs to change. They aren't ever called with an empty string.
This function takes a string with a beginning and ending pointer. It doesn't dereference if the string is empty, and returns the correct value when empty, and does get called with empty strings.
These functions take a string argument with beginning and ending positions. They handle the case of an empty string properly, and the documentation says they handle empty strings.
Calls in this file to these functions bypassed the macros, with no harm currently done. But it isn't good practice.
This internal function can handle empty strings, but it isn't ever called with one so far, and it is better practice to not call it with an empty string
This internal function looks problematic with regard to handling empty strings, but it isn't ever called with one so far. Change to catch such calls that might get added in the future.
This internal function takes a string argument with beginning and ending positions. It handles the case of an empty string properly.
This internal function takes a string argument with beginning and ending positions. It is called all the time with an empty string,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These have not been done in earlier commits because they needed more manual analysis, which I have now done. In a couple cases, I changed the EPTR assert to EPTRgt, based on that analysis.