[V2] dns: use getbyname #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@tsloughter I'd appreciate if you could look over this, given you're more Erlang-y than me |
tsloughter
reviewed
Dec 8, 2024
| %% so we just catch the error and return an unknown error. I'm not sure | ||
| %% what causes these. | ||
| lookup(Name, Type, Timeout) when is_binary(Name) -> | ||
| try lookup_throws(Name, Type, Timeout) of |
There was a problem hiding this comment.
Waaa!? Well this is good to know, thanks :)
tsloughter
reviewed
Dec 8, 2024
src/barnacle_ffi.erl
Outdated
| end. | ||
|
|
||
| lookup_throws(Name, Type, Timeout) when is_binary(Name) -> | ||
| io:format("Name: ~p~n", [Name]), |
There was a problem hiding this comment.
Suggested change
| io:format("Name: ~p~n", [Name]), |
Think you left this my mistake.
tsloughter
reviewed
Dec 8, 2024
| Ok(list.concat([a_records, aaaa_records])) | ||
| } | ||
|
|
||
| fn format_ip_address(ip: IpAddress) -> String { |
There was a problem hiding this comment.
Do you do this in Gleam instead of calling inet:ntoa/1 to avoid going back to an Erlang tuple and external ffi?
Contributor
Author
There was a problem hiding this comment.
I mostly didn't know that function existed, but I like to keep things in Gleam where possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3