add ipv6 support #5
Conversation
|
Hark! We're scanning your PR for issues. Stand by for comments. Beep boop, |
![rover-app[bot]](https://avatars.githubusercontent.com/in/1111559?s=60&v=4){kind=small}
There was a problem hiding this comment.
Scanned on Jun 29th 2025, 12:34PM for commit 3fb0827333ceb0c1675a3a5e3b757f8ce58ab974
Rover found 1 risk.
1 medium.
One medium severity issue found.
To request another review, comment @rover-app review in the PR discussion.
Rover Support
Rover has scanned for issues in performance, security, reliability that might be introduced by this PR, in the context of your upstream and downstream services and dependencies.
What happens next
You can re-request a review by commenting @rover-app review on the PR.
Rover will review the PR again, and close any alerts that you've fixed.
I want to follow up with Rover
PR chat is coming
Soon, you'll be able to talk to Rover about issues in your PR, in your PR.
Right now, we only support code chat on your `main`/`master` (default) branch:
head to the graph page on the Rover platform
to chat with your code.
If Rover isn't doing much
It could be that Rover doesn't support your language or framework yet, or perhaps you've found an area we can improve in!
We'd love to get your feedback to help improve Rover, so if you're not happy with its output please get in touch by clicking here.
I love/hate the alerts Rover is generating
Regardless, we'd love to hear it!
We're working hard to make Rover better,
so please get in touch with us
with your PR number and alert comment.
I'd like to request a feature or improvement
You know the score: get in touch!
We love to have feature requests from our users to work on.
Rover actions
Re-review
Comment @rover-app review on the PR to request another review.
Suspend Rover scanning
To stop Rover from scanning PRs on your org (Pevensie), head to your organization settings or suspend the GitHub app installation on this GitHub account.
| mug.new(config.host, config.port) | ||
| |> mug.ip_version_preference(mug.Ipv6Preferred) | ||
| |> mug.timeout(timeout) |
There was a problem hiding this comment.
The code ignores the user-configured `ip_version_preference` setting and always uses `mug.Ipv6Preferred` when establishing connections.
Severity medium
Description
The `create_socket` function uses a hardcoded IPv6 preference setting (`mug.Ipv6Preferred`) instead of using the `ip_version_preference` value from the provided configuration. This effectively renders the newly added configuration option useless, as any user-specified IP version preference will be ignored during actual connection establishment.Suggested fix
| mug.new(config.host, config.port) | |
| |> mug.ip_version_preference(mug.Ipv6Preferred) | |
| |> mug.timeout(timeout) | |
| mug.new(config.host, config.port) | |
| |> mug.ip_version_preference(config.ip_version_preference) | |
| |> mug.timeout(timeout) |
Closes #3